emilymye commented on a change in pull request #13517:
URL: https://github.com/apache/beam/pull/13517#discussion_r541346292
##########
File path: sdks/go/container/build.gradle
##########
@@ -47,12 +47,14 @@ golang {
}
}
+def defaultTag = project.rootProject.hasProperty(["docker-tag"]) ?
[project.rootProject["docker-tag"], 'latest'] : ['latest']
Review comment:
ah, I see. Would it work to just ignore docker-tag for dockerTagPush and
just use one flag like docker-tags or docker-tag-list? Mostly I don't quite
like the idea of splitting the tag flag - if docker-tags isn't given, we can
just construct a list from docker-tag, or use `["latest"]`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
