pabloem commented on pull request #13726:
URL: https://github.com/apache/beam/pull/13726#issuecomment-758265059


   hi @janeliulwq ! Can you share more info about what this change means? What 
sorts of objects can be part of this? How are they encoded? Examples would be 
great.
   
   This may not be a breaking change if existing pipelines will work (will 
they?) - if they will not work, then we may need to work around this. A 
possibility would be to add two separate methods:
   
   ```
   public PTransform<PC<KV<String, Map<String, Object>>>, FhirIO.Search.Result> 
searchFull (?){
     return new Search<Object>(...);
   }
   
   // Original method remains unchanged
   public PTransform<PC<KV<String, Map<String, String>>>, FhirIO.Search.Result> 
search  {
     return new Search<String>(...);
   }
   
   // The class uses generics
   class Search extends PTransform<PC<KV<String, Map<String, T>>>, 
FhirIO.Search.Result> {
   }
   ```
   
   I am not sure. Thoughts?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to