janeliulwq commented on pull request #13726: URL: https://github.com/apache/beam/pull/13726#issuecomment-758304893
On a second thought, existing pipelines will probably be broken by this change (though I suspect no existing pipelines are using this). I like your proposal of the Search class using generics, I have updated the implementation, PTAL & thanks! In terms of what this change means, for my specific use case, I need to pass in List<String> as search parameter values (for when a search parameter has multiple values). I could potentially just change the type to Map<String, List<String>>, but given this experience, I feel that I should leave the connector as generic as possible and take in "Object" just like the FHIR API does, and let the downstream user decide what types of Object they want to pass in and write their own encoder. Lmk if this makes sense. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
