y1chi commented on pull request #14120: URL: https://github.com/apache/beam/pull/14120#issuecomment-788465020
So IIUC, SortingFlinkCombineRunner merges IntevalWindow based on whether two windows are intersecting with each other, and does not bother to invoke the mergeWindows function from the WindowFn. This seems inconsistent with other runners such as DirectRunner or DataflowRunner, where we rely on the merge implementation in WindowFn without making an assumption. So the change I made here is simply removing the usage of SortingFlinkCombineRunner since its assumption seems unsafe. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
