reuvenlax commented on pull request #14718: URL: https://github.com/apache/beam/pull/14718#issuecomment-832086336
Can you explain exactly what the issue is? Setting a timer for time T with an output timestamp of T + delta seems a bit weird to me. The bug says that the user has no way of knowing what the timer's fire timestamp is, but that's not true - this information is easily available. On Tue, May 4, 2021 at 9:21 AM Kenn Knowles ***@***.***> wrote: > I think your change is correct. Essentially reverting the prior change, > which broke things. On the bug it seems we found a bug in how cleanup > timers were fired (for just Dataflow? for everyone?) and instead of fixing > the bug we broke the feature with this check. CC @steveniemitz > <https://github.com/steveniemitz> and @reuvenlax > <https://github.com/reuvenlax>. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/14718#issuecomment-832070801>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFAYJVNBQDDL2VKW33XBN4TTMANJNANCNFSM44CKPPKQ> > . > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
