reuvenlax commented on pull request #14718:
URL: https://github.com/apache/beam/pull/14718#issuecomment-832108998


   The fire timestamp for the timer should be the timestamp of the timer
   itself, not the current input watermark. One way to get is is using
   OnTimerContext.fireTimestamp. You can also get it by adding a @Timestamp
   parameter to the onTimer function, which will be filled in using the fire
   timestamp.
   
   On Tue, May 4, 2021 at 10:17 AM Jan Lukavský ***@***.***>
   wrote:
   
   > @reuvenlax <https://github.com/reuvenlax> the problem is with relative
   > timers. I'm not aware of a way to get the input watermark, which is the
   > firing timestamp for relative event time timer with zero offset. Which is
   > tested in the test case.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/beam/pull/14718#issuecomment-832106898>, or
   > unsubscribe
   > 
<https://github.com/notifications/unsubscribe-auth/AFAYJVKCLW2M3WAUWK3NATLTMAT4HANCNFSM44CKPPKQ>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to