reuvenlax commented on pull request #14718: URL: https://github.com/apache/beam/pull/14718#issuecomment-832134625
Disallowing the output timestamp being later than the input timestamp doesn't make any sense -the input watermark is a lower bound, so will usually be less than anything being processed. If that's what the code is doing today, then it's clearly wrong. On Tue, May 4, 2021 at 10:51 AM Jan Lukavský ***@***.***> wrote: > No, you can verify that by running the test without the changed > precondition. > I'm not sure if relative timer based ob element's timestamp makes sense to > me. Using input watermark makes perfect analogy with relative processing > time timers, at least as I understand the concept. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/14718#issuecomment-832128322>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFAYJVMQD26FJE5BSBGSJI3TMAXYXANCNFSM44CKPPKQ> > . > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
