ajamato commented on a change in pull request #14490:
URL: https://github.com/apache/beam/pull/14490#discussion_r631541650



##########
File path: 
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java
##########
@@ -262,6 +265,8 @@ public static void main(
                     }
                   });
 
+      MetricsEnvironment.setProcessWideContainer(new 
MetricsContainerImpl(null));

Review comment:
       Moving this to https://github.com/apache/beam/pull/14805
   
   Unfortunately I could not make MetricsEnvironment instantiate a 
MetricsContainerImpl inside itself as this would create a dep cycle between 
their packages. So keeping this one as is.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to