ajamato commented on a change in pull request #14490:
URL: https://github.com/apache/beam/pull/14490#discussion_r631541888
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/CounterCell.java
##########
@@ -94,6 +99,11 @@ public MetricName getName() {
return name;
}
+ @Override
+ public @Nullable DateTime getStartTime() {
Review comment:
Moving this to https://github.com/apache/beam/pull/14805
I don't want to make the system call to get the time for every metric as
you suggested due to performance concerns. So I make only the process wide
MetricContainer make this call. So it should be called once for the process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
