ajamato commented on a change in pull request #14490:
URL: https://github.com/apache/beam/pull/14490#discussion_r631541707
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsContainerImpl.java
##########
@@ -84,7 +86,10 @@
private MetricsMap<KV<MetricName, HistogramData.BucketType>, HistogramCell>
histograms =
new MetricsMap<>(HistogramCell::new);
- /** Create a new {@link MetricsContainerImpl} associated with the given
{@code stepName}. */
+ /**
+ * Create a new {@link MetricsContainerImpl} associated with the given
{@code stepName}. If
+ * stepName is null, this MetricsContainer is not bound to a step.
Review comment:
Moving this to https://github.com/apache/beam/pull/14805
Done in the new PR
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsContainerImpl.java
##########
@@ -74,6 +74,8 @@
protected final @Nullable String stepName;
+ private boolean isProcessWide = false;
Review comment:
Moving this to https://github.com/apache/beam/pull/14805
Done in the new PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
