iemejia commented on a change in pull request #14854:
URL: https://github.com/apache/beam/pull/14854#discussion_r637219166
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java
##########
@@ -151,7 +150,8 @@ private Bounded(@Nullable String name, BoundedSource<T>
source) {
.apply(ParDo.of(new OutputSingleSource<>(source)))
.setCoder(SerializableCoder.of(new
TypeDescriptor<BoundedSource<T>>() {}))
.apply(ParDo.of(new BoundedSourceAsSDFWrapperFn<>()))
- .setCoder(source.getOutputCoder());
+ .setCoder(source.getOutputCoder())
+
.setTypeDescriptor(source.getOutputCoder().getEncodedTypeDescriptor());
Review comment:
You are right and I don't know why we don't pay more attention to this.
Probably because coders seem to include the TypeDescriptor, any ideas
@kennknowles ? is this redundant somehow?
In any case having this information seems important for the downstream
transforms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
