boyuanzz commented on a change in pull request #14854:
URL: https://github.com/apache/beam/pull/14854#discussion_r637245096
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java
##########
@@ -151,7 +150,8 @@ private Bounded(@Nullable String name, BoundedSource<T>
source) {
.apply(ParDo.of(new OutputSingleSource<>(source)))
.setCoder(SerializableCoder.of(new
TypeDescriptor<BoundedSource<T>>() {}))
.apply(ParDo.of(new BoundedSourceAsSDFWrapperFn<>()))
- .setCoder(source.getOutputCoder());
+ .setCoder(source.getOutputCoder())
+
.setTypeDescriptor(source.getOutputCoder().getEncodedTypeDescriptor());
Review comment:
It seems like the `typeDescriptor` can be inferred from
`Coder.getEncodedTypeDescriptor()`. If we really want to populate this
information in a consistent way, probably we can consider changing
`PCollection.getTypeDescriptor()` to infer the `typeDescriptor` from `Coder` if
the `typeDescriptor` is set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
