iemejia commented on a change in pull request #14854:
URL: https://github.com/apache/beam/pull/14854#discussion_r638299198
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java
##########
@@ -151,7 +150,8 @@ private Bounded(@Nullable String name, BoundedSource<T>
source) {
.apply(ParDo.of(new OutputSingleSource<>(source)))
.setCoder(SerializableCoder.of(new
TypeDescriptor<BoundedSource<T>>() {}))
.apply(ParDo.of(new BoundedSourceAsSDFWrapperFn<>()))
- .setCoder(source.getOutputCoder());
+ .setCoder(source.getOutputCoder())
+
.setTypeDescriptor(source.getOutputCoder().getEncodedTypeDescriptor());
Review comment:
I like @boyuanzz fix because even in the presence of different Coders
the TypeDescriptor is commonly preserved inside of the Coders. WDYT
@kennknowles can you spot some particular issues about it?
I can rebase this PR targetting a generic implementation like the one on
#14870 but I did not do it like that because I was not really familiar with the
reasoning behind not relying on the coder typeDescriptor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
