kw2542 commented on a change in pull request #14923:
URL: https://github.com/apache/beam/pull/14923#discussion_r644185526
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/ExternalEnvironmentFactory.java
##########
@@ -113,6 +113,7 @@ public RemoteEnvironment createEnvironment(Environment
environment, String worke
ManagedChannelFactory.createDefault().forDescriptor(externalPayload.getEndpoint());
BeamFnApi.StartWorkerResponse startWorkerResponse =
BeamFnExternalWorkerPoolGrpc.newBlockingStub(managedChannel)
+ .withWaitForReady()
Review comment:
Good point, it should be separated out in a different PR at least.
My thought on this is similar as the job server request that when runner
connects to external service, it is possible that external service may not be
up and running yet if we bring up external service together with the main job.
In addition, there may be intermittent errors, therefore, `withWaitForReady`
seems to be a good candidate here.
I also think that we could provide customizable deadline/timeout here too
which requires changes to external_payload model.
What are your thoughts on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
