ibzib commented on a change in pull request #14923:
URL: https://github.com/apache/beam/pull/14923#discussion_r644188136
##########
File path:
runners/portability/java/src/main/java/org/apache/beam/runners/portability/PortableRunner.java
##########
@@ -201,12 +207,16 @@ public PipelineResult run(Pipeline pipeline) {
.setPreparationId(prepareJobResponse.getPreparationId())
.build();
- RunJobResponse runJobResponse = jobService.run(runJobRequest);
+ // Run the job and wait for a result, we don't set a timeout here because
+ // it may take a long time for a job to complete and streaming
+ // jobs currently never return a response.
+ RunJobResponse runJobResponse =
jobService.withDeadline(null).run(runJobRequest);
Review comment:
I prefer removing it. The comment is sufficient to show our intent here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
