ibzib commented on a change in pull request #14923:
URL: https://github.com/apache/beam/pull/14923#discussion_r644194340
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/ExternalEnvironmentFactory.java
##########
@@ -113,6 +113,7 @@ public RemoteEnvironment createEnvironment(Environment
environment, String worke
ManagedChannelFactory.createDefault().forDescriptor(externalPayload.getEndpoint());
BeamFnApi.StartWorkerResponse startWorkerResponse =
BeamFnExternalWorkerPoolGrpc.newBlockingStub(managedChannel)
+ .withWaitForReady()
Review comment:
If I understand correctly, adding `withWaitForReady` will make requests
that formerly failed fast instead block forever. Therefore, I don't think we
should add `withWaitForReady` without also adding a timeout, since otherwise
the user gets no feedback about why their pipeline is stalled. And I think the
timeout should be off by default, since most deployments don't have a problem
with starting the external service ahead of time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
