ibzib commented on pull request #15082: URL: https://github.com/apache/beam/pull/15082#issuecomment-872581895
> > I don't see how this would be different with annotations. We don't need to move any options, just capture a subset. (To be clear, I was imagining something like `ExpansionServiceOptions extends PortableEnvironmentOptions, ExperimentalOptions`.) > > Yes, inheritance works the same, if we can easily do that, then it would be OK in this sense. Still, it would require that all the options (`PortableEnvironmentOptions`) be respected by `ExpansionServiceOptions`, which is not the case. That's why I propose separating out PortableEnvironmentOptions from PortablePipelineOptions. It'd be like this: PortableEnvironmentOptions PortablePipelineOptions extends PortableEnvironmentOptions, ... ExpansionServiceOptions extends PortableEnvironmentOptions, ExperimentalOptions Ideally though we wouldn't need ExperimentalOptions, as we're discussing on the mailing list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
