je-ik edited a comment on pull request #15082: URL: https://github.com/apache/beam/pull/15082#issuecomment-872519819
> Creating ExternalServiceOptions doesn't mean we need to define new options. For example, we could refactor environment-related options into a new PortableEnvironmentOptions class, and then make both PortablePipelineOptions and ExternalServiceOptions extend PortableEnvironmentOptions. That makes sense, but that applies to current state only, right? When a new option is added, would the author of the change know exactly where to put the option? The ExternalServiceOptions 'look' like being applied to external service only. That is not the case. And we would have to move complete ExperimentalOptions to ExternalServiceOptions, which seems problematic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
