ibzib commented on pull request #15082:
URL: https://github.com/apache/beam/pull/15082#issuecomment-872531325


   Oops -- I meant to say ExpansionServiceOptions.
   
   > The ExternalServiceOptions 'look' like being applied to external service 
only. That is not the case.
   
   I'm not sure what you mean here.
   
   > And we would have to move complete ExperimentalOptions to 
ExternalServiceOptions, which seems problematic.
   
   I don't see how this would be different with annotations. We don't need to 
move any options, just capture a subset. (To be clear, I was imagining 
something like `ExpansionServiceOptions extends PortableEnvironmentOptions, 
ExperimentalOptions`.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to