echauchot commented on pull request #15257: URL: https://github.com/apache/beam/pull/15257#issuecomment-892937377
> Changes LGTM, with the exception of Dataflow pre commit tests failing. The failing checks seem entirely unrelated, but I'm not certain. > > @echauchot Over to you for final approval or comment regarding failing/flaky Dataflow precommit tests Test logs[1] seem to indicate an error determining whether the Dataflow job was successful or not: > > ``` > WARNING: Dataflow job 2021-08-03_06_12_06-18435283618356752107 did not output a success or failure metric. > Aug 03, 2021 1:18:37 PM org.apache.beam.runners.dataflow.DataflowPipelineJob logTerminalState > INFO: Job 2021-08-03_06_12_06-18435283618356752107 finished with status DONE. > ``` > > [1] https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Commit/15174/testReport/org.apache.beam.examples/WordCountIT/testE2EWordCount/ Thanks @andresrc for your work and thanks @egalpin for the review ! Dataflow examples tests are failing in my PRs also and on PRs I saw lately so it seems to be totally unrelated. I'll merge either way but it is 10pm here now, so I'll take a better look tomorrow and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
