echauchot commented on pull request #15257: URL: https://github.com/apache/beam/pull/15257#issuecomment-892949942
> I wonder if we should move towards (please don't hate me for suggesting it Etienne ) pre-commit unit tests that don't make use of ES itself but analyze the resulting in-memory PCollection contents to ensure that what's been produced is as expected. We could still employ post-commit/regression tests that use a real ES instance, but this could de-flake the pre-commit unit tests? Don't worry Evan, I do agree, ES tests have been flaky for years because of embedded ES being sensitive to load. We tried to lower flakiness with test containers (thanks for your work on that) but there is still. Flaky Utests are painful for the build so they are painful for the whole dev process. So now comes the time to set a limit with which we're confident in UTests to spot all misbehavior and leave the rest to ITests. Only, in that case, these IO ITests need to run as part of each PR, which is not done right now: e.g. CassandraioIT and ESIOIT are run on an on-demand basis for load tests mainly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
