echauchot commented on a change in pull request #15257:
URL: https://github.com/apache/beam/pull/15257#discussion_r683438274
##########
File path:
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
##########
@@ -1512,10 +1528,14 @@ static String createBulkApiEntity(DocToBulk spec,
String document, int backendVe
isDelete = spec.getIsDeleteFn().apply(parsedDocument);
}
}
+ final boolean isAppendOnly = Boolean.TRUE.equals(spec.getAppendOnly());
if (isDelete) {
+ checkState(!isAppendOnly, "No deletions allowed for append-only
indices");
// delete request used for deleting a document
return String.format("{ \"delete\" : %s }%n", documentMetadata);
+ } else if (isAppendOnly) {
Review comment:
very good point Evan !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
