riteshghorse commented on a change in pull request #15430:
URL: https://github.com/apache/beam/pull/15430#discussion_r700379772
##########
File path: sdks/go/test/integration/primitives/windowinto.go
##########
@@ -110,7 +117,7 @@ func TriggerDefault(s beam.Scope) {
col := teststream.Create(s, con)
windowSize := 10 * time.Second
- validate(s.Scope("Fixed"), window.NewFixedWindows(windowSize), col,
window.Trigger{Kind: window.DefaultTrigger}, window.Accumulating, 6.0, 9.0)
+ validateEquals(s.Scope("Fixed"), window.NewFixedWindows(windowSize),
col, window.TriggerDefault(), window.Discarding, 6.0, 9.0)
Review comment:
To keep it consistent with other trigger tests. The expected output will
still be the same as before because the firing is done only once at the end of
window.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
