lostluck commented on a change in pull request #15430:
URL: https://github.com/apache/beam/pull/15430#discussion_r700596951
##########
File path: sdks/go/pkg/beam/core/graph/window/trigger.go
##########
@@ -35,3 +35,38 @@ const (
NeverTrigger string = "Trigger_Never_"
AfterSynchronizedProcessingTimeTrigger string =
"Trigger_AfterSynchronizedProcessingTime_"
)
+
+// TriggerDefault constructs a default trigger that fires after the end of
window.
+// No provision for late arriving data.
Review comment:
Please update the comments with the missing information. In this case
that late data is discarded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
