ibzib commented on pull request #15174: URL: https://github.com/apache/beam/pull/15174#issuecomment-917201142
@benWize Thanks, that fixed the error. The tests are no longer crashing, but 6 failures remain: - aggregation_queries_test:aggregation_array_agg_1 - aggregation_queries_test:array_agg_empty_input - aggregation_queries_test:aggregation_36 - aggregation_queries_test:aggregation_53 - aggregation_queries_test:aggregation_58 - aggregation_queries_test:aggregation_62 https://github.com/google/zetasql/blob/dd883180de6387ad80bcf7534b5aae8191e66621/zetasql/compliance/testdata/aggregation_queries.test I took a quick look at the errors, and it seems they are all related to null handling. (I'm guessing these are all test cases where the SQL query failed to compile before, but now they're compiling and giving wrong answers.) - Some functions are expected to return null when the input is empty. - BIT_AND, BIT_OR, etc. are expected to ignore null input mixed with non-null inputs. I think the current implementations of these functions in Beam are incorrect. The compliance tests are the source of truth. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
