ibzib commented on pull request #15174: URL: https://github.com/apache/beam/pull/15174#issuecomment-918719763
Hi @benWize the operators for BIT_OR etc. are taken from Calcite's SqlStdOperatorTable. https://github.com/apache/beam/blob/be083918108579d07780a23f179e2bd62b3abcfe/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperatorMappingTable.java#L79 To override their return type inference, we will need replace the operators from SqlStdOperatorTable with custom operators defined in SqlOperators, and make sure nullability is set correctly. For example, BIT_XOR already has a custom operator, but it looks like the return type is non-null. https://github.com/apache/beam/blob/be083918108579d07780a23f179e2bd62b3abcfe/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperators.java#L164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
