ibzib commented on pull request #15174: URL: https://github.com/apache/beam/pull/15174#issuecomment-919517308
> Thanks, @ibzib I fixed null handling for BitXor with your suggestion, and for the case of `array_agg` I tried overriding type to > `x -> createSqlType(SqlTypeName.ARRAY, true)` > https://github.com/apache/beam/blob/dcc1812ab1cee26e09c3d6c3c6d3fe2496ac4f65/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperators.java#L92 > > > but an assert fails with `java.lang.AssertionError: use createArrayType() instead` > I looked into `createArrayType()` implementation, and it creates an `ArraySqlType` with `nullable = false`. ArraySqlType has a public constructor, so can't we just call it directly with nullable = true? https://calcite.apache.org/javadocAggregate/org/apache/calcite/sql/type/ArraySqlType.html#%3Cinit%3E(org.apache.calcite.rel.type.RelDataType,boolean) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
