chamikaramj commented on a change in pull request #15606:
URL: https://github.com/apache/beam/pull/15606#discussion_r732248624
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ExternalTransformBuilder.java
##########
@@ -44,4 +47,12 @@
/** Builds the transform after it has been configured. */
PTransform<InputT, OutputT> buildExternal(ConfigT configuration);
+
+ /**
+ * List the dependencies needed for this transform. Jars from classpath are
used by default when
+ * Optional.empty() is returned.
+ */
Review comment:
I believe you were going to update this by passing in the ConfigT object
to getDependencies() call as well ? I think this makes sense since this gives
more control by making config parameters available during dependency selection.
(for example, select correct set of dependencies for JDBC based on the Database
and the version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
