chamikaramj commented on a change in pull request #15606:
URL: https://github.com/apache/beam/pull/15606#discussion_r732267632
##########
File path:
sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java
##########
@@ -371,6 +382,23 @@ default InputT createInput(Pipeline p, Map<String,
PCollection<?>> inputs) {
return extractOutputs(
Pipeline.applyTransform(name, createInput(p, inputs),
getTransform(spec)));
}
+
+ default List<String> getDependencies(PipelineOptions options) {
+ List<String> filesToStage =
options.as(PortablePipelineOptions.class).getFilesToStage();
+ if (filesToStage == null || filesToStage.isEmpty()) {
Review comment:
Probably you should sync to reflect changes here:
https://github.com/apache/beam/pull/15638
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ExternalTransformBuilder.java
##########
@@ -44,4 +47,12 @@
/** Builds the transform after it has been configured. */
PTransform<InputT, OutputT> buildExternal(ConfigT configuration);
+
+ /**
+ * List the dependencies needed for this transform. Jars from classpath are
used by default when
Review comment:
Is this in addition to the dependencies provided through the
CLASSPATH/filesToStage option or should this provide the full set of
dependencies used for this transform ?
Also, should this be a complete list, including transitive dependencies ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
