je-ik commented on a change in pull request #15994:
URL: https://github.com/apache/beam/pull/15994#discussion_r768115403
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/state/FlinkStateInternals.java
##########
@@ -215,6 +216,22 @@ public void clearGlobalState() {
}
}
+ public List<ByteBuffer> getGlobalWindowStateKeys() {
Review comment:
> Oh you were talking about enhancing the current Flink API. I'm pretty
sure we don't want to do that, it could actually clash with some on-going
efforts (changelog state backend) and tie our hands in further development of
state backends
Why's that? Having an API like `iterateUniqueKeys`, seems to be able to have
a default (in-mem) implementation, while it could be optimized for cases where
the backend has sorted keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
