je-ik commented on a change in pull request #15994:
URL: https://github.com/apache/beam/pull/15994#discussion_r768128529
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/state/FlinkStateInternals.java
##########
@@ -215,6 +216,22 @@ public void clearGlobalState() {
}
}
+ public List<ByteBuffer> getGlobalWindowStateKeys() {
Review comment:
I don't think there is any state, that would be guaranteed to be present
for every window. That would require such state to be part of the Beam model
and AFAIK there is no such state. Watermark hold might definitely be absent
when there is nothing holding the watermark (no timer with output timestamp).
What comes close is window GC timer state, but even that can be optimized
out for some cases (e.g. GlobalWindow). I think we should not rely on any
internal detail, because that would be fragile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
