je-ik commented on a change in pull request #15994:
URL: https://github.com/apache/beam/pull/15994#discussion_r768140274
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/state/FlinkStateInternals.java
##########
@@ -215,6 +216,22 @@ public void clearGlobalState() {
}
}
+ public List<ByteBuffer> getGlobalWindowStateKeys() {
Review comment:
I don't know internal details of Flink. If there is no reliable way to
get list of unique windows (which feels weird, but maybe it is possible), then
we should simply resort to in-memory set. Either way, that is the cleanest for
this PR, because any changes in Flink API would be long-term.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
