phoerious commented on a change in pull request #15931:
URL: https://github.com/apache/beam/pull/15931#discussion_r768493618
##########
File path: sdks/python/apache_beam/io/aws/clients/s3/boto3_client.py
##########
@@ -67,6 +69,11 @@ def __init__(self, options):
aws_secret_access_key=secret_access_key,
aws_session_token=session_token)
+ self._download_request = None
Review comment:
I haven't had any issues with that on a Flink backend. I don't know the
SDK in detail, but I don't think it creates any issues, because the entire
behaviour of the client is still idempotent (just less efficient if you don't
read sequentially). The user should not be aware of the statefulness, because
it does not matter for the API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
