phoerious commented on a change in pull request #15931:
URL: https://github.com/apache/beam/pull/15931#discussion_r768514890
##########
File path: sdks/python/apache_beam/io/aws/clients/s3/boto3_client.py
##########
@@ -67,6 +69,11 @@ def __init__(self, options):
aws_secret_access_key=secret_access_key,
aws_session_token=session_token)
+ self._download_request = None
Review comment:
If an instance is used to process two connections simultaneously, the
client should reset the connection before each range request and effectively
fall back to the old behaviour. The same happens when you read
non-sequentially. The only issue I can see here if the client is used in a
non-thread-safe way, but I don't want to add mutex locks unless I know that
this is definitely a scenario that can occur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
