phoerious commented on a change in pull request #15931:
URL: https://github.com/apache/beam/pull/15931#discussion_r768538855
##########
File path: sdks/python/apache_beam/io/aws/clients/s3/boto3_client.py
##########
@@ -92,27 +99,65 @@ def get_object_metadata(self, request):
boto_response['ContentLength'],
boto_response['ContentType'])
+ item.size = max(item.size - self._download_offset, 0)
return item
+ def get_stream(self, request, start):
Review comment:
I got the tests to run, but I am honestly ad a loss how to add proper
tests for that. All the existing tests are on a mock S3 client. The real
S3Client class is entirely untested and cannot be tested effectively without a
running S3 backend server.
##########
File path: sdks/python/apache_beam/io/aws/clients/s3/boto3_client.py
##########
@@ -92,27 +99,65 @@ def get_object_metadata(self, request):
boto_response['ContentLength'],
boto_response['ContentType'])
+ item.size = max(item.size - self._download_offset, 0)
return item
+ def get_stream(self, request, start):
Review comment:
I got the tests to run, but I am honestly at a loss how to add proper
tests for that. All the existing tests are on a mock S3 client. The real
S3Client class is entirely untested and cannot be tested effectively without a
running S3 backend server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
