dpcollins-google commented on a change in pull request #16319:
URL: https://github.com/apache/beam/pull/16319#discussion_r774234510



##########
File path: 
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1244,7 +1237,7 @@ class BeamModulePlugin implements Plugin<Project> {
 
           project.dependencies {
             shadowTestRuntimeClasspath it.project(path: project.path, 
configuration: "shadowTest")
-            shadowTestRuntimeClasspath it.project(path: project.path, 
configuration: "compileOnly")

Review comment:
       This changes shadowTest targets from depending on the compile only 
classpath of the underlying target to depending on the implementation. If 
everything runs, it should not affect any artifacts.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to