dpcollins-google commented on a change in pull request #16319:
URL: https://github.com/apache/beam/pull/16319#discussion_r774235965
##########
File path: runners/spark/job-server/spark_job_server.gradle
##########
@@ -52,9 +52,9 @@ configurations.all {
dependencies {
implementation project(sparkRunnerProject)
permitUnusedDeclared project(sparkRunnerProject)
- implementation project(path: sparkRunnerProject, configuration:
"compileOnly")
+ implementation project(sparkRunnerProject)
validatesPortableRunner project(path: sparkRunnerProject, configuration:
"testRuntimeMigration")
- validatesPortableRunner project(path: sparkRunnerProject, configuration:
"compileOnly")
Review comment:
The implementation change may affect this artifact- things that are
listed as compileOnly deps of sparkRunnerProject will not be listed as provided
of the job-server artifact- they will only exist as provided transitively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
