dpcollins-google commented on a change in pull request #16319:
URL: https://github.com/apache/beam/pull/16319#discussion_r774240341
##########
File path: runners/spark/job-server/spark_job_server.gradle
##########
@@ -52,9 +52,9 @@ configurations.all {
dependencies {
implementation project(sparkRunnerProject)
permitUnusedDeclared project(sparkRunnerProject)
- implementation project(path: sparkRunnerProject, configuration:
"compileOnly")
+ implementation project(sparkRunnerProject)
validatesPortableRunner project(path: sparkRunnerProject, configuration:
"testRuntimeMigration")
- validatesPortableRunner project(path: sparkRunnerProject, configuration:
"compileOnly")
Review comment:
Actually, I'll revise this. previously, this wouldn't have listed
transitive deps as provided, it would just have declared a dependency on the
library itself, just a different configuration of it (compileOnly vs the full
target), so shouldn't affect the output artifact
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
