tvalentyn commented on a change in pull request #16633:
URL: https://github.com/apache/beam/pull/16633#discussion_r796189613
##########
File path: sdks/python/apache_beam/runners/portability/stager_test.py
##########
@@ -723,6 +765,65 @@ def test_remove_dependency_from_requirements(self):
self.assertEqual(['apache_beam\n', 'avro-python3\n', 'numpy\n'],
sorted(lines))
+ def _create_file(
+ self, requirements_file, temp_dir, populate_cache_with_sdists):
+ if not populate_cache_with_sdists:
+ self.create_temp_file(os.path.join(temp_dir, 'nothing.whl'), 'Fake whl')
+ self.create_temp_file(
+ os.path.join(temp_dir, 'nothing.tar.gz'), 'Fake tarball')
+ else:
+ self.create_temp_file(
+ os.path.join(temp_dir, 'nothing.tar.gz'), 'Fake tarball')
Review comment:
I meant that you can add `nothing.tar.gz` outside the `if` since this
code is in both branches. But feel free to keep as is if you think it's more
clear this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
