clandry94 commented on a change in pull request #16690:
URL: https://github.com/apache/beam/pull/16690#discussion_r797065234
##########
File path:
sdks/java/io/elasticsearch-tests/elasticsearch-tests-7/src/test/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOTest.java
##########
@@ -83,6 +83,12 @@ public void setup() throws IOException {
@Rule public TestPipeline pipeline = TestPipeline.create();
+ @Test
Review comment:
IT feels wrong making a unit test in this file for the
`SslConfiguration` class as all the other tests in this file are hitting an
Elasticsearch cluster. I don't really have any need to do that here as we know
that the ES client works with a valid SSL config. Really, I just want to test
that SslConfiguration serializes properly and that pipelines still init as
expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
