clandry94 commented on a change in pull request #16690:
URL: https://github.com/apache/beam/pull/16690#discussion_r797066238
##########
File path:
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
##########
@@ -309,6 +309,71 @@ static JsonNode parseResponse(HttpEntity responseEntity)
throws IOException {
return responses;
}
+ @AutoValue
+ public abstract static class SslConfiguration implements Serializable {
+ public abstract @Nullable String getKeystoreType();
+
+ public abstract @Nullable String getKeystorePath();
+
+ public abstract @Nullable String getKeystorePassword();
+
+ public abstract @Nullable TrustStrategy getTrustStrategy();
+
+ abstract Builder builder();
+
+ @AutoValue.Builder
+ abstract static class Builder {
+ abstract Builder setKeystoreType(String type);
Review comment:
Aside from reorganizing classes, the biggest win of this PR is exposing
the ability for pipeline developers to use their keystore of choice- jks,
pkcs12, etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
