clandry94 commented on a change in pull request #16690:
URL: https://github.com/apache/beam/pull/16690#discussion_r797067206
##########
File path:
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
##########
@@ -517,7 +590,9 @@ public ConnectionConfiguration withBearerToken(String
bearerToken) {
public ConnectionConfiguration withKeystorePath(String keystorePath) {
checkArgument(keystorePath != null, "keystorePath can not be null");
checkArgument(!keystorePath.isEmpty(), "keystorePath can not be empty");
- return builder().setKeystorePath(keystorePath).build();
+ return builder().setSslConfiguration(
Review comment:
I've modified the existing ssl config methods to delegate to the new
SslConfiguration class so nothing breaks on release. Should we add a
deprecation warning to these methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
