chamikaramj commented on a change in pull request #16784:
URL: https://github.com/apache/beam/pull/16784#discussion_r802165065
##########
File path: sdks/java/io/google-cloud-platform/expansion-service/build.gradle
##########
@@ -35,5 +35,13 @@ dependencies {
permitUnusedDeclared project(":sdks:java:expansion-service") // BEAM-11761
implementation project(":sdks:java:io:google-cloud-platform")
permitUnusedDeclared project(":sdks:java:io:google-cloud-platform") //
BEAM-11761
+ implementation project(":sdks:java:extensions:schemaio-expansion-service")
+ permitUnusedDeclared
project(":sdks:java:extensions:schemaio-expansion-service") // BEAM-11761
Review comment:
Probably you just need to depend on
"https://github.com/apache/beam/blob/master/sdks/java/extensions/schemaio-expansion-service/src/main/java/org/apache/beam/sdk/extensions/schemaio/expansion/ExternalSchemaIOTransformRegistrar.java";
not the full expansion service (including all the shaded jars) right ?
I think in the future we should consider just moving that class to "core" or
to a new module that both expansion services depend on. This change should be
OK if it does not bloat the size of google-cloud-platform jar too much
(certainly better than the other way around).
cc: @TheNeuralBit
##########
File path: sdks/java/io/google-cloud-platform/expansion-service/build.gradle
##########
@@ -35,5 +35,13 @@ dependencies {
permitUnusedDeclared project(":sdks:java:expansion-service") // BEAM-11761
implementation project(":sdks:java:io:google-cloud-platform")
permitUnusedDeclared project(":sdks:java:io:google-cloud-platform") //
BEAM-11761
+ implementation project(":sdks:java:extensions:schemaio-expansion-service")
+ permitUnusedDeclared
project(":sdks:java:extensions:schemaio-expansion-service") // BEAM-11761
Review comment:
(let's create a Jira for this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
