TheNeuralBit commented on a change in pull request #16784:
URL: https://github.com/apache/beam/pull/16784#discussion_r803031040
##########
File path: sdks/java/io/google-cloud-platform/expansion-service/build.gradle
##########
@@ -35,5 +35,13 @@ dependencies {
permitUnusedDeclared project(":sdks:java:expansion-service") // BEAM-11761
implementation project(":sdks:java:io:google-cloud-platform")
permitUnusedDeclared project(":sdks:java:io:google-cloud-platform") //
BEAM-11761
+ implementation project(":sdks:java:extensions:schemaio-expansion-service")
+ permitUnusedDeclared
project(":sdks:java:extensions:schemaio-expansion-service") // BEAM-11761
Review comment:
Ok fair point, but regardless I think what we're both proposing is
aligned. I'm just suggesting that instead of making a new extension to contain
[`ExternalSchemaIOTransformRegistrar.java`](https://github.com/apache/beam/blob/master/sdks/java/extensions/schemaio-expansion-service/src/main/java/org/apache/beam/sdk/extensions/schemaio/expansion/ExternalSchemaIOTransformRegistrar.java)
we can leave it where it is, and move away from publishing a shaded expansion
service jar with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
