TheNeuralBit commented on a change in pull request #16784:
URL: https://github.com/apache/beam/pull/16784#discussion_r802965491
##########
File path: sdks/java/io/google-cloud-platform/expansion-service/build.gradle
##########
@@ -35,5 +35,13 @@ dependencies {
permitUnusedDeclared project(":sdks:java:expansion-service") // BEAM-11761
implementation project(":sdks:java:io:google-cloud-platform")
permitUnusedDeclared project(":sdks:java:io:google-cloud-platform") //
BEAM-11761
+ implementation project(":sdks:java:extensions:schemaio-expansion-service")
+ permitUnusedDeclared
project(":sdks:java:extensions:schemaio-expansion-service") // BEAM-11761
Review comment:
schemaio-expansion-service actually is just that class already, it just
pulls in other dependencies and publishes a shaded jar. With this change the
only other use of the schemaio-expansion-service shaded jar is for jdbc:
https://github.com/apache/beam/blob/1ef5056383195eb25374f8a2815d6fffb1b5e823/sdks/go/pkg/beam/io/xlang/jdbcio/jdbc.go#L64
https://github.com/apache/beam/blob/8578c9a9352a8a5c9621647e9c585321f9761dc5/sdks/python/apache_beam/io/jdbc.py#L98
We could instead make a jdbc expansion service, and stop creating a shaded
jar for schemaio-expansion-service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
