egalpin commented on PR #17297: URL: https://github.com/apache/beam/pull/17297#issuecomment-1135936227
Thanks @nishantjain91 👍 @aaltay I'm actually stuck philosophically regarding how to go about testing and what ought to be tested. I don't expect that there should be tests across the codebase to ensure the correct usage of other APIs and external modules nor their behaviour. Ex. it would be silly to test the built-in Java addition operator. In the case covered by @nishantjain91's work, I suppose the most correct way to test is by integration test against an ES cluster with certs. That just strikes me as a lot of overhead for one use case. That said, if it happened to be the most common use case, it would be well worth the overhead. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
