egalpin commented on PR #17297: URL: https://github.com/apache/beam/pull/17297#issuecomment-1141253230
Thanks @aaltay 👍 I'd propose that we move forward with merging this code as-is despite lack of test coverage at the moment, and separately track adding test coverage[1]. Though I don't like that idea in general, the existing code has no test coverage either (hence the need for this change now rather than having caught the issue previously), and the changes in this PR represent a net-positive change in functionality without regression of existing tests. @nishantjain91 can you confirm whether username + password is used in any of the tests? Thoughts? [1] https://issues.apache.org/jira/browse/BEAM-14531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
