tvalentyn commented on code in PR #17244: URL: https://github.com/apache/beam/pull/17244#discussion_r870146064
########## sdks/python/apache_beam/io/gcp/gcsfilesystem.py: ########## @@ -38,6 +40,15 @@ class GCSFileSystem(FileSystem): CHUNK_SIZE = gcsio.MAX_BATCH_OPERATION_SIZE # Chuck size in batch operations GCS_PREFIX = 'gs://' + def __init__(self, pipeline_options): + super().__init__(pipeline_options) + if isinstance(pipeline_options, PipelineOptions): + gcs_options = pipeline_options.view_as(GoogleCloudOptions) + impersonate_service_account = gcs_options.impersonate_service_account Review Comment: +1 to Kenn's comment. This looks strange to me as well. Can we make pipeline options a parameter of get_service_credentials() and adjust credential generation and usages of this method accordingly? Given that: - credential is a global singleton - pipeline options are also global, you could clear the gcs_options.impersonate_service_account within the code that creates the credential singleton. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
