tvalentyn commented on code in PR #17244: URL: https://github.com/apache/beam/pull/17244#discussion_r872622468
########## sdks/python/apache_beam/internal/gcp/auth.py: ########## @@ -59,16 +73,19 @@ def set_running_in_gce(worker_executing_project): executing_project = worker_executing_project -def get_service_credentials(): +def get_service_credentials(pipeline_options): """For internal use only; no backwards-compatibility guarantees. Get credentials to access Google services. + Args: + pipeline_options: Pipeline options, used in creating credentials Review Comment: I'd say something here like: Pipeline options. Required on initial credential initialization when the impersonate_service_account option is provided, otherwise passing `None` is acceptable. You can do it in a follow up change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
