tvalentyn commented on code in PR #17244:
URL: https://github.com/apache/beam/pull/17244#discussion_r870710311
##########
sdks/python/apache_beam/internal/gcp/auth.py:
##########
@@ -160,3 +167,26 @@ def _get_service_credentials():
'Connecting anonymously.',
e)
return None
+
+ @staticmethod
+ def _add_impersonation_credentials(credentials, pipeline_options):
+ if not pipeline_options:
+ return credentials
+ if isinstance(pipeline_options, PipelineOptions):
+ gcs_options = pipeline_options.view_as(GoogleCloudOptions)
+ impersonate_service_account = gcs_options.impersonate_service_account
+ else:
+ impersonate_service_account = pipeline_options.get(
Review Comment:
When would this param be not PipelineOptions?
If somehow this value is dictionary, this call will crash with key error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
